feat(property-mapping): add support for configurable Guid format #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncipollina
requested changes
Jan 16, 2026
Contributor
ncipollina
left a comment
ncipollina
left a comment
There was a problem hiding this comment.
I really want to be able to specify format on a per field basis.
| /// </item> | ||
| /// </list> | ||
| /// </remarks> | ||
| public string GuidFormat { get; set; } = "D"; |
Contributor
There was a problem hiding this comment.
🔄 I don't like these being separate fields. I would rather have a single Format string field. Depending on what the type is, that would determine where/how the format is applied.
Contributor
There was a problem hiding this comment.
We should be applying these on the DynamoFieldAttribute.
Collaborator
Author
There was a problem hiding this comment.
This is the overall format for all items. I am adding per-field formats next.
ncipollina
previously approved these changes
Jan 16, 2026
Contributor
ncipollina
left a comment
ncipollina
left a comment
There was a problem hiding this comment.
✅ The requested change will be handled in a future PR.
- Added `GuidFormat` option to `MapperOptions` with a default format of "D". - Updated `TypeMappingStrategyResolver` to respect the Guid format specified in `MapperOptions`. - Enhanced `PropertyMappingCodeRenderer` to handle type-specific arguments, including the Guid format. - Updated `DynamoMapperAttribute` to expose the `GuidFormat` option and document valid formats.
- Added instructions to mention related issues in the PR body. - Clarified the use of `closes #<issue number>` for resolving issues. - Updated the PR template to include related issues or PRs.
j-d-ha
force-pushed
the
feature/Add-Guid-Format-Override-Support
branch
from
9194756 to
dc05483
Compare
… setup - Standardized syntax for dictionary and list initializations in tests. - Added trailing commas for multi-line collections to improve diff readability. - Replaced `Assert.Equal` with `Assert.Single` where applicable for clarity. - Improved parameter naming in `GetGuid` method calls across tests. refactor(Guid-handling): refine methods for Guid parsing with customizable format - Removed redundant Guid parsing methods to avoid code duplication. - Introduced default "D" format for `Guid` and nullable `Guid` parsing methods. - Simplified method signatures to improve usability and consistency. - Updated XML documentation to clarify `format` defaults and valid format strings.
…rameters - Removed redundant `format:` named parameters in method calls across test snapshots. - Updated property mappings to use positional arguments where applicable. - Simplified type-specific argument handling by treating all arguments as positional in `PropertyMappingSpecBuilder`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
This PR adds support for configurable Guid format strings in DynamoMapper, allowing developers to control how Guid values are serialized to and from DynamoDB. The default format remains "D" (hyphenated format), but users can now specify alternative formats like "N" (no hyphens), "B" (braces), or "P" (parentheses) via the
GuidFormatproperty on the[DynamoMapper]attribute.Key Changes:
GuidFormatproperty toMapperOptions(internal) andDynamoMapperAttribute(public API)TypeMappingStrategyResolverto pass format string when mapping Guid typesPropertyMappingCodeRendererto correctly position theout varparameter after type-specific arguments✅ Checklist
🧪 Related Issues or PRs
Part of Phase 1 implementation for property-level customization.
💬 Notes for Reviewers
The key technical challenge here was adjusting the parameter ordering in
PropertyMappingCodeRenderer.cs(lines 98-104). Previously, theout varparameter was always inserted at position 1, but with type-specific arguments like format strings, it needs to be inserted after those arguments. The fix calculates the correct position dynamically based onFromTypeSpecificArgs.Length.This change maintains backward compatibility since the default Guid format remains "D", matching the existing behavior.